sql: add pg_catalog.pg_isolation_test_session_is_blocked builtin
#116708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Informs cockroachdb#95771. This commit adds the pg_catalog.pg_isolation_test_session_is_blocked builtin, which supports Postgres' isolationtester. The function checks if the specified PID is blocked by any of the PIDs listed in the second argument. Currently, this only looks for blocking caused by waiting for locks. This is an undocumented function intended for use by the isolation tester. It is not intended for use by end users. While here, fix the signature of pg_blocking_pids and leave a TODO to implement the builtin using `crdb_internal.cluster_locks`. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/pgIsoRegress
branch
from
4ee4212
to
d22f081
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
rafiss
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
lgtm! just had very minor nits
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
-- commits line 19 at r1:
is pg_blocking_pids also internal? if not, then maybe the signature change should be in a release note
pkg/sql/sem/builtins/pg_builtins.go line 2027 at r1 (raw file):
// tester, and may change in future releases as required for testing // purposes. "pg_isolation_test_session_is_blocked": makeBuiltin(defProps(),
instead of defProps(), we could use one with Undocumented: true:
tree.FunctionProperties{
Category: builtinconstants.CategorySystemInfo, // or maybe CategoryCompatibility
Undocumented: true,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #95771.
This commit adds the
pg_catalog.pg_isolation_test_session_is_blockedbuiltin, which supports Postgres' isolationtester.The function checks if the specified PID is blocked by any of the PIDs listed in the second argument. Currently, this only looks for blocking caused by waiting for locks.
This is an undocumented function intended for use by the isolation tester. It is not intended for use by end users.
While here, fix the signature of
pg_catalog.pg_blocking_pidsand leave a TODO to implement the builtin usingcrdb_internal.cluster_locks.Release note: None