ui: add lease preference metrics to replication dashboard #116709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
force-pushed
the
231218.ui-lease-pref-repl-dashboard
branch
2 times, most recently
from
7b8a272
to
5f38adf
Compare
|
|
Lease preference metrics were added in cockroachdb#107505, however were only visible in DB Console via custom metrics. This commit adds the `leases.preferences.violating` and `leases.preferences.less-preferred` metrics to the replication dashboard under a new lease preferences graph. Resolves: cockroachdb#116678 Release note (ui change): Introduce a new lease preferences graph on the replication dashboard. The lease preferences graph will display when the current leaseholder is not the first lease preference and where the current leaseholder satisfies no applied lease preference.
kvoli
force-pushed
the
231218.ui-lease-pref-repl-dashboard
branch
from
5f38adf
to
19fa4ba
Compare
|
TYFTR bors r=andrewbaptist |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lease preference metrics were added in #107505, however were only
visible in DB Console via custom metrics. This commit adds the
leases.preferences.violatingandleases.preferences.less-preferredmetrics to the replication dashboard under a new lease preferences
graph.
Resolves: #116678
Release note (ui change): Introduce a new lease preferences graph on the
replication dashboard. The lease preferences graph will display when the
current leaseholder is not the first lease preference and where the
current leaseholder satisfies no applied lease preference.