-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: changefeedccl: fix custom key column when used with CDC queries #116967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, CDC custom key column caused incorrect behaviour with CDC queries, leading to a `retryable error: No column with name <name> in this row`. This was because we forgot to add columns to `colsByName` map when generating projection rows for CDC queries. This caused [`DatumNamed`](https://github.com/cockroachdb/cockroach/blob/8d74d10e77f020dd0f5c98003f7976b63531de18/pkg/ccl/changefeedccl/cdcevent/event.go#L116-L122) to return a column not found error, This patch addresses the issue by populating the `colsByName` map during the addition of columns for CDC queries. Note that the issue with supporting `ALTER CHANGEFEED` with CDC queries remains unresolved. Fixes: #114196 Release note (bug fix): CDC custom key column now functions with CDC queries correctly. For example, `CREATE CHANGEFEED WITH key_column=..., unordered AS SELECT * FROM table` now works correctly instead of retrying forever. Note that some functionalities with CDC custom keys are not fully supported, see 115267 for more details.
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
miretskiy
approved these changes
Jan 2, 2024
nicktrav
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #115163 on behalf of @wenyihu6.
/cc @cockroachdb/release
Previously, CDC custom key column caused incorrect behaviour with CDC queries,
leading to a
retryable error: No column with name <name> in this row
. This wasbecause we forgot to add columns to
colsByName
map when generating projectionrows for CDC queries. This caused
DatumNamed
to return a column not found error. This patch addresses the issue by populating
the
colsByName
map during the addition of columns for CDC queries. Note thatthe issue with supporting
ALTER CHANGEFEED
with CDC queries remainsunresolved.
Fixes: #114196
Release note (bug fix): CDC custom key column now functions with CDC queries
correctly. For example,
CREATE CHANGEFEED WITH key_column=..., unordered AS SELECT * FROM table
now works correctly instead of retrying forever. Note thatsome functionalities with CDC custom keys are not fully supported, see 115267
for more details.
Release justification: bug fixes for CDC custom key column when used with CDC queries