sql: respect IF NOT EXISTS in CREATE EXTERNAL CONNECTION #117312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
requested review from
adityamaru and
msbutler
and removed request for
a team,
msbutler and
adityamaru
msbutler
approved these changes
Jan 10, 2024
| @@ -144,6 +144,10 @@ func (p *planner) createExternalConnection( | |||
| // Create the External Connection and persist it in the | |||
| // `system.external_connections` table. | |||
| if err := ex.Create(params.ctx, txn); err != nil { | |||
| isNotExists := n.ConnectionLabelSpec.IfNotExists | |||
There was a problem hiding this comment.
nit: s/is/if/r
also, I think a few words in the commit message could be swapped for clearer reading.
Previously, while the IF NOT EXISTS syntax was allowed nothing checked the boolean on the constructed tree node. Here, we check the boolean and elide DuplicateViolation errors from create. Fixes cockroachdb#116997 Release note (bug fix): CREATE EXTERNAL CONNECTION IF NOT EXISTS no longer returns an error if the connection already exists.
stevendanna
force-pushed
the
fix-116997
branch
from
05c2dfa
to
e13823c
Compare
|
bors r=msbutler |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, while the IF NOT EXISTS syntax was allowed nothing checked the boolean on the constructed tree node. Here, we check the boolean and elide DuplicateViolation errors from create.
Fixes #116997
Release note (bug fix): CREATE EXTERNAL CONNECTION IF NOT EXISTS no longer returns an error if the connection already exists.