Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: server: fix total latency time on sql stats call #117426

Merged
merged 1 commit into from Jan 8, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 5, 2024

Backport 1/1 commits from #116976 on behalf of @maryliag.

/cc @cockroachdb/release


For the top activity tables, we have a column execution_total_cluster_seconds with the total latency of all executions of that period. This value is important because the top activity table have up to 500 rows per aggregated timestamp, so if we add all latencies from it, we won't have the total, only the total of the top. We then have a column that has that total of that hour which is based on the main table.
Previously, when making a request to the top activity table we were returning only of of those values as the total, which works as expected if your select is in a single aggregation period. The majority of requests won't be this way, so we need to add the values from all aggregated period selects.

This commit update the query for the total select to get one value from each aggregated_ts and then adding those.

Part Of CRDB-34884

Release note (bug fix): Fix value used for the total runtime on sql stats, which was using the wrong value previously, causing the UI to display values with more than 100%.


Release justification: bug fix

For the top activity tables, we have a column `execution_total_cluster_seconds`
with the total latency of all executions of that period.
This value is important because the top activity table have
up to 500 rows per aggregated timestamp, so if we add all
latencies from it, we won't have the total, only the total of the top.
We then have a column that has that total of that hour which is
based on the main table.
Previously, when making a request to the top activity table
we were returning only of of those values as the total, which
works as expected if your select is in a single aggregation period.
The majority of requests won't be this way, so we need to add the values
from all aggregated period selects.

This commit update the query for the total select to get
one value from each aggregated_ts and then adding those.

Part Of CRDB-34884

Release note (bug fix): Fix value used for the total runtime on sql stats,
which was using the wrong value previously, causing the UI to display values
with more than 100%.
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 5, 2024 21:40
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-116976 branch from 3c9b8f0 to 6bf526d Compare January 5, 2024 21:40
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 5, 2024 21:40
@blathers-crl blathers-crl bot requested review from abarganier and removed request for a team January 5, 2024 21:40
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 5, 2024
Copy link
Author

blathers-crl bot commented Jan 5, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 5, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from mgartner January 8, 2024 15:49
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @abarganier, @blathers-crl[bot], @maryliag, @petermattis, and @xinhaoz)


-- commits line 12 at r1:
nit: "of of" => "one of" (I think?)

@maryliag maryliag merged commit 86dc159 into release-23.2 Jan 8, 2024
5 of 6 checks passed
@maryliag maryliag deleted the blathers/backport-release-23.2-116976 branch January 8, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants