changefeedccl: Correctly handle stable CDC query functions #117520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom CDC query functions rely on having "annotations" configured. Prior to this change, these annotations were configured when the CDC query was being evaluated (for each event). However, CDC query also needs to be evaluated when e.g. the changefeed is being created. In this case, the correct annotations were not configured, resulting in failure to create changefeed that use stable, custom CDC function. At this point, there is only one such function: `changefeed_creation_time`. This PR refactors and cleans up how semantic and evalution contexts are configured. This now happens in a single place -- namely the `withPlanner` helper so that correct information is configured at all times. Fixes cockroachdb#115245 Release note (enterprise change): Fix CDC query to correctly handle `changefeed_creation_time()` function.
|
This change is |
miretskiy
added
backport-23.1.x
jayshrivastava
approved these changes
Jan 9, 2024
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 3ddb521 to blathers/backport-release-23.1-117520: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom CDC query functions rely on having "annotations" configured. Prior to this change, these annotations were configured when the CDC query was being evaluated (for each event). However, CDC query also needs to be evaluated when e.g. the changefeed is being created. In this case, the correct annotations were not configured, resulting in failure to create changefeed that use stable, custom CDC function. At this point, there is only one such function:
changefeed_creation_time.This PR refactors and cleans up how semantic and evalution contexts are configured. This now happens in a single place -- namely the
withPlannerhelper so that correct information is configured at all times.Fixes #115245
Release note (enterprise change): Fix CDC query to correctly handle
changefeed_creation_time()function.