rpc: rm rangefeed RPC stream window special case #117545
Conversation
The rangefeed stream window size tuning was introduced to mitigate OOM in rangefeeds caused by the excessive number of streams (one per Range). Since we now use mux rangefeeds (which multiplexes all the rangefeed traffic into a single stream), this setting is no longer needed, so this commit removes it. Release note (ops change): COCKROACH_RANGEFEED_RPC_INITIAL_WINDOW_SIZE env variable has been removed, and rangefeed connection now uses the same window size as other RPC connections.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Is the non-mux code removed completely, or just disabled by default? If the code is still there, should we postpone removing this option, and remove it together with the code? |
The code is still there, to serve 23.2 clients in mixed-version clusters and for testing of the legacy endpoints. However, there is no way for a user to enable use of non-mux rangefeeds as an RPC client on a 24.1 node (the cluster settings and such are gone), so outbound RPC connections from a 24.1 node will never use non-mux rangefeeds. |
|
bors r=erikgrinaker,miretskiy |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
The rangefeed stream window size tuning was introduced to mitigate OOM in rangefeeds caused by the excessive number of streams (one per
Range). Since we now use mux rangefeeds (which multiplexes all the rangefeed traffic into a single stream), this setting is no longer needed, so this commit removes it.Part of #108992
Release note (ops change):
COCKROACH_RANGEFEED_RPC_INITIAL_WINDOW_SIZEenv variable has been removed, and rangefeed connection now uses the same window size as other RPC connections.