Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: a few fixes for schema change watchdog #117580

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jan 9, 2024

The log message it created on failure did not produce readable output. Also, the watchdog could get confused if a query completed and the session ended up in an idle state.

fixes #117533
Release note: None

The log message it created on failure did not produce readable output.
Also, the watchdog could get confused if a query completed and the
session ended up in an idle state.

Release note: None
@rafiss rafiss added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Jan 9, 2024
@rafiss rafiss requested a review from fqazi January 9, 2024 20:43
@rafiss rafiss requested a review from a team as a code owner January 9, 2024 20:43
@rafiss rafiss requested review from srosenberg and renatolabs and removed request for a team January 9, 2024 20:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @srosenberg)

@rafiss
Copy link
Collaborator Author

rafiss commented Jan 11, 2024

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 11, 2024

Build succeeded:

@craig craig bot merged commit 695f7ef into cockroachdb:master Jan 11, 2024
9 checks passed
@rafiss rafiss deleted the fix-schema-change-watchdog branch January 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload failed
3 participants