kv/reports: don't panic on missing default zone config #117662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs cockroachdb#43951. In cockroachdb#43951, we saw that some random sequence on queries led to the default zone configuration in the system.zones table (key `/Table/5/1/0/2/1`) being deleted. This led to a fatal log in the replication report generation code. Deleting this key should not be allowed, but it also shouldn't crash cockroach. This commit replaces the fatal log with an error, which is logged a few stack frames up with a gentle "some reports have not been generated" message. I've confirmed that with this fix, the reproduction steps in cockroachdb#43951 no longer lead to a fatal log and a crashed process. Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
shralex
approved these changes
Jan 11, 2024
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #43951.
In #43951, we saw that some random sequence on queries led to the default zone configuration in the system.zones table (key
/Table/5/1/0/2/1) being deleted. This led to a fatal log in the replication report generation code.Deleting this key should not be allowed, but it also shouldn't crash cockroach. This commit replaces the fatal log with an error, which is logged a few stack frames up with a gentle "some reports have not been generated" message.
I've confirmed that with this fix, the reproduction steps in #43951 no longer lead to a fatal log and a crashed process.
Release note: None