Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate CI docker images to GCP #117663

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

rail
Copy link
Member

@rail rail commented Jan 11, 2024

Previously, we used Docker Hub to host our CI docker images.

To improve service reliability, this PR moves the used docker images to GAR.

Part of: DEVINF-915
Epic: RE-539
Release note: None

@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf A-release T-release Release Engineering & Automation Team backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Jan 11, 2024
@rail rail self-assigned this Jan 11, 2024
@rail rail requested review from a team as code owners January 11, 2024 05:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail rail marked this pull request as draft January 11, 2024 06:00
@rail rail force-pushed the dockerhub-migrate branch 4 times, most recently from b2f0a0c to d86632e Compare January 11, 2024 14:45
Previously, we used Docker Hub to host our CI docker images.

To improve service reliability, this PR moves the used docker images to
GAR.

Part of: DEVINF-915
Epic: RE-539
Release note: None
@jlinder
Copy link
Collaborator

jlinder commented Jan 11, 2024

I was so excited to see this change happen that I jumped the gun and reviewed it while still a draft. 🤪 NM that review.

@rail
Copy link
Member Author

rail commented Jan 11, 2024

It's fine. The change is ready to go, after I verify we can push the docker images from CI. No code changes expected, only permissions.

@rail rail marked this pull request as ready for review January 11, 2024 14:52
@rail
Copy link
Member Author

rail commented Jan 11, 2024

bors r=jlinder

@craig
Copy link
Contributor

craig bot commented Jan 11, 2024

Build failed:

@rail
Copy link
Member Author

rail commented Jan 11, 2024

bors retry

@craig
Copy link
Contributor

craig bot commented Jan 11, 2024

This PR was included in a batch that timed out, it will be automatically retried

@rail
Copy link
Member Author

rail commented Jan 11, 2024

bors retry

@craig
Copy link
Contributor

craig bot commented Jan 11, 2024

Already running a review

@craig
Copy link
Contributor

craig bot commented Jan 11, 2024

Build succeeded:

@craig craig bot merged commit d424c50 into cockroachdb:master Jan 11, 2024
9 checks passed
Copy link

blathers-crl bot commented Jan 11, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from f67e1ea to blathers/backport-release-23.1-117663: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from f67e1ea to blathers/backport-release-23.2-117663: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system A-release backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf T-release Release Engineering & Automation Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants