New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: sql: use high priority for populating RoleMemberCache #117712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-117258
branch
from
January 12, 2024 00:00
3618883
to
1615096
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Jan 12, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Jan 12, 2024
rafiss
approved these changes
Jan 12, 2024
rafiss
reviewed
Jan 12, 2024
Previously, when the RoleMemberCache is invalid, it launches a new txn in a singleflight to read from `system.role_members` table to populate the cache. If, however, the original txn has previously laid a write intent on the same system table, then we end up having a deadlock: original txn waits for this new txn; this new txn waits for original txn This commit therefore make the singleflight txn high priority so that it won't be blocked by the original txn. However, if the original txn is already high priority, the deadlock becomes possible again. Fortunately, in this case, txn in retry is a prerequisite for the deadlock to occur (see #117258 (comment)) so our solution to it is to not use singleflight to populate RoleMemberCache if txn is high priority and in retry but instead directly use txn itself to read and return the result. Release note (bug fix): Fixed a bug where concurrent GRANTs can cause deadlocks.
Xiang-Gu
force-pushed
the
blathers/backport-release-23.1-117258
branch
from
January 16, 2024 15:03
1615096
to
a947138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #117258 on behalf of @Xiang-Gu.
/cc @cockroachdb/release
Previously, when the RoleMemberCache is invalid, it launches a new txn in a singleflight to read from
system.role_members
table to populate the cache. If, however, the original txn has previously laid a write intent on the same system table, then we end up having a deadlock: original txn waits for this new txn; this new txn waits for original txn.Fixes #117144
Release note (bug fix): Fixed a bug where concurrent GRANTs can cause deadlocks.
Release justification: important bug fixes