util/log/eventpb: direct cluster settings events to the OPS channel #117923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
maryliag
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier)
The OPS channel is documented as reporting "point" operational events such as those initiated by human interactions, including cluster settings. Emitting cluster setting events to the DEV channel was likely a mistake, not intentional. Epic: none Release note (ops change): Events for cluster setting changes are now emitted to the OPS channel rather than the DEV channel.
petermattis
force-pushed
the
pmattis/cluster-settings-events
branch
from
58bbb10
to
ca11487
Compare
|
TFTR! bors r+ |
1 similar comment
|
TFTR! bors r+ |
|
Already running a review |
|
TFTR! bors r+ |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OPS channel is documented as reporting "point" operational events such as
those initiated by human interactions, including cluster settings. Emitting
cluster setting events to the DEV channel was likely a mistake, not
intentional.
Epic: none
Release note (ops change): Events for cluster setting changes are now emitted
to the OPS channel rather than the DEV channel.