Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfig: correctly order updates when applying in the KVSubscriber #118001

Merged
merged 1 commit into from
Feb 5, 2024

Commits on Feb 5, 2024

  1. spanconfig: correctly order updates when applying in the KVSubscriber

    Previously, there was no ordering guarantee between KVSubscriber
    events at the same timestamp. As a result, if a batch of events
    included updates to overlapping spans at the same timestamp, we could
    apply additions before deletions -- this would cause the additions to
    get clobbered, which was not the intention. This could lead to missing
    span configurations, resulting in bugs such as the linked issue.
    
    This patch fixes the issue by sorting deletions before additions if
    two span configuration events have the same timestamp.
    
    Closes cockroachdb#110908
    
    Release note (bug fix): Previously, altering from a Regional By Row
    table to a Regional By Table table could cause leaseholders to never
    move to the databse's primary region. This is now fixed.
    arulajmani committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    73cb0da View commit details
    Browse the repository at this point in the history