sql: add autocommit_before_ddl setting #118440
Conversation
|
This change is |
rafiss
force-pushed
the
ddl-autocommit
branch
from
8d47688
to
948c22d
Compare
pkg/sql/conn_executor_exec.go
Outdated
| @@ -2241,11 +2257,13 @@ func (ex *connExecutor) handleTxnRowsWrittenReadLimits(ctx context.Context) erro | |||
| // transaction contains multiple statements, and an upgrade was attempted, an | |||
| // error is returned. | |||
| func (ex *connExecutor) maybeUpgradeToSerializable(ctx context.Context, stmt Statement) error { | |||
| var txnSchemaChangeErr = pgerror.Newf( | |||
There was a problem hiding this comment.
This should be defined globally as opposed to in this function (which will allocate a new one every time)
rafiss
force-pushed
the
ddl-autocommit
branch
3 times, most recently
from
7be749f
to
58011c7
Compare
There was a problem hiding this comment.
Reviewed 8 of 9 files at r1, 4 of 4 files at r4, 2 of 2 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @rafiss)
-- commits line 21 at r5:
*application
pkg/sql/conn_executor_exec.go line 2258 at r6 (raw file):
var txnSchemaChangeErr = pgerror.Newf( pgcode.FeatureNotSupported, "to use multi-statement transactions involving a schema change under weak isolation levels, enable the autocommit_before_ddl setting",
Is the plan to make this the default behaviour for read committed out of the box? i.e. Serializable default to the old behaviour and read committed has this implicitly set
There was a problem hiding this comment.
Reviewable status:
Previously, fqazi (Faizan Qazi) wrote…
*application
fixed
pkg/sql/conn_executor_exec.go line 2258 at r6 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Is the plan to make this the default behaviour for read committed out of the box? i.e. Serializable default to the old behaviour and read committed has this implicitly set
in the very long term maybe, but there's no plan to do that. for now, we decided to just guide people towards the setting so it stays opt-in, since it's a pretty significant behavior change that people should know what they are signing up for.
This setting can be used to improve compatibility with some tools that do not work well due to our limitations with schema changes in explicit transactions. It also can be used to use schema changes under READ COMMITTED more easily, without needing to teach the schema changer about READ COMMITTED. Release note (sql change): Added the autocommit_before_ddl session variable. When set to true, any schema change statement that is sent during an explicit transaction will cause the transaction to commit before executing the schema change.
With this setting on, COMMIT, ROLLBACK, and other statements that normally cause errors when used outside of an explicit transaction are instead treated as warnings. This is because the setting can cause a transaction to end earlier than an application may expect. Release note: None
Update the error message returned when using schema changes under READ COMMITTED to hint towards using the autocommit_before_ddl setting. Release note: None
rafiss
force-pushed
the
ddl-autocommit
branch
from
58011c7
to
4b9b150
Compare
|
tftr! bors r+ |
|
Build succeeded: |
|
Was there any particular reason we didn't go with Ben's suggestion to do COMMIT; DDL; BEGIN; instead of COMMIT; DDL;? |
fixes #87236
informs #87233
This setting can be used to improve compatibility with some tools that
do not work well due to our limitations with schema changes in explicit
transactions. It also can be used to use schema changes under READ
COMMITTED more easily, without needing to teach the schema changer about
READ COMMITTED.
Release note (sql change): Added the autocommit_before_ddl session
variable. When set to true, any schema change statement that is sent
during an explicit transaction will cause the transaction to commit
before executing the schema change.
sql: handle COMMIT outside of txn when autocommit_before_ddl is on
With this setting on, COMMIT, ROLLBACK, and other statements that
normally cause errors when used outside of an explicit transaction are
instead treated as warnings. This is because the setting can cause a
transaction to end earlier than an application may expect.
sql: add hint to use autocommit_before_ddl setting
Update the error message returned when using schema changes under READ
COMMITTED to hint towards using the autocommit_before_ddl setting.