sql: enable read committed cluster setting by default #118479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
nvanbenschoten
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @michae2, @rafiss, and @srosenberg)
pkg/sql/logictest/testdata/logic_test/txn line 237 at r1 (raw file):
statement ok SE CLUSTER SETTING sql.txn.read_committed_isolation.enabled = false
CI is complaining about the SET misspelling.
rafiss
force-pushed
the
enable-rc-default
branch
from
ff6073d
to
be010d0
Compare
Release note (sql change): The sql.txn.read_committed_isolation.enabled cluster setting is now true by default. This means that any syntax and settings that configure the READ COMMITTED isolation level will now cause the transaction to use that isolation level, rather than automatically upgrading the transaction to SERIALIZABLE.
rafiss
force-pushed
the
enable-rc-default
branch
from
be010d0
to
dae54bd
Compare
|
tftr! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic CRDB-34172
Release note (sql change): The sql.txn.read_committed_isolation.enabled cluster setting is now true by default. This means that any syntax and settings that configure the READ COMMITTED isolation level will now cause the transaction to use that isolation level, rather than automatically upgrading the transaction to SERIALIZABLE.