sql: fix usages of internal executor to delegate from user transaction #118640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
This patch adds the ability to inject an isql.Txn into a KVAccessor. This makes it possible to make the KVAccessor use an internal executor that is tied to the outer transaction's state, rather than using the internal executor that is initialized during node startup. Release note: None
Release note: None
|
This change is |
fqazi
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Nice find
Reviewed 1 of 1 files at r1, 14 of 14 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler)
|
tftr! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fix a few usages of the internal executor to use the new interface which delegates to an internal executor that shares the outer txn's state.
For ease of review, the testing for this is in a separate PR (where the bugs were discovered): #107990
informs #100178