sql: add goroutine_id to show sessions #118644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
force-pushed
the
session-goroutine
branch
3 times, most recently
from
d584972
to
c9f1b51
Compare
maryliag
requested review from
abarganier and
a team
and removed request for
a team
Add the column goroutine_id to the result of `SHOW SESSIONS`. Also adding the column to the views: `crdb_internal.node_sessions` and `crdb_internal.cluster_sessions`. Fixes cockroachdb#117625 Release note (sql change): Add column `goroutine_id` to the response of the `SHOW SESSIONS` command.
maryliag
force-pushed
the
session-goroutine
branch
from
c9f1b51
to
ec72121
Compare
rafiss
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
lgtm! nice work
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @abarganier)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the column goroutine_id to the result of
SHOW SESSIONS. Also adding the column to the views:crdb_internal.node_sessionsandcrdb_internal.cluster_sessions.Fixes #117625
Release note (sql change): Add column
goroutine_idto the response of theSHOW SESSIONScommand.