Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: keep track of per-stmt read committed retries #118653

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 2, 2024

This change makes it possible to view automatic retries performed under read committed txns in the DB Console.

fixes #113986
Release note: None

@rafiss rafiss requested review from nvanbenschoten, michae2 and a team February 2, 2024 16:55
Copy link

blathers-crl bot commented Feb 2, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @rafiss)


pkg/sql/txn_state.go line 80 at r1 (raw file):

		// autoRetryCounter keeps track of the number of automatic retries that
		// have occurred. It includes per-statement retries performed under READ
		// COMMITTED as well as transaction retries for serialization failures.

"for serialization failures under SNAPSHOT and SERIALIZABLE"

This change makes it possible to view automatic retries performed under
read committed txns in the DB Console.

Release note: None
Copy link
Collaborator Author

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tftr!

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @michae2 and @nvanbenschoten)


pkg/sql/txn_state.go line 80 at r1 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

"for serialization failures under SNAPSHOT and SERIALIZABLE"

done

@craig
Copy link
Contributor

craig bot commented Feb 2, 2024

Build succeeded:

@craig craig bot merged commit 9434801 into cockroachdb:master Feb 2, 2024
9 checks passed
@rafiss rafiss deleted the rc-retry-o11y branch February 3, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: observability for number of per-statement retries under READ COMMITTED
3 participants