-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: builtins: allow VIEWACTIVITY priv to use crdb_internal.request_statem… #118809
Conversation
1f785b7
to
8c55a25
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
8c55a25
to
9e5c8e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @dhartunian)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you just move the import back to where it should be? (and check your editor's linter settings 😇)
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @blathers-crl[bot] and @xinhaoz)
pkg/sql/sem/builtins/builtins.go
line 22 at r1 (raw file):
gojson "encoding/json" "fmt" "github.com/cockroachdb/cockroach/pkg/sql/roleoption"
nit: why is this diff in here?
9e5c8e0
to
dd33011
Compare
…ent_bundle Previously only those with the VIEWACTIVITY role could use the crdb_internal.request_statement_bundle builtin. We should allow the VIEWACTIVITY privilege as well since role options are now deprecated. This allow also allow stmt bundle requests to be made from db-console for users with this granted privilege. Epic: none Fixes: #118759 Release note (bug fix): Those with VIEWACTIVITY privilege can now request statement bundles using crdb_internal.requets_statement_bundle or via db-console's sql activity page.
dd33011
to
b268b65
Compare
Backport 1/1 commits from #118760 on behalf of @xinhaoz.
/cc @cockroachdb/release
…ent_bundle
Previously only those with the VIEWACTIVITY role could use the crdb_internal.request_statement_bundle builtin. We should allow the VIEWACTIVITY privilege as well since role options are now deprecated. This allow also allow stmt bundle requests to be made from db-console for users with this granted privilege.
Epic: none
Fixes: #118759
Release note (bug fix): Those with VIEWACTIVITY privilege can now request statement bundles using crdb_internal.requets_statement_bundle or via db-console's sql activity page.
Release justification: bug fix - use privilege instead of deprecated role