cli: update docs url for sql shell #118960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
The SQL shell help function redirects the user to use-the-built-in-sql-client.html this page no longer exists. Instead the SQL shell should point to cockroach-sql.html. Epic: None Release note (cli change): Change the SQL shell help URL to point to cockroach-sql.html.
lunevalex
force-pushed
the
alex/fix-redirect
branch
from
4a29df0
to
1c84dba
Compare
mdlinville
approved these changes
Feb 8, 2024
| @@ -276,7 +276,7 @@ func (c *cliState) printCliHelp() { | |||
| fmt.Fprintf(c.iCtx.stdout, helpMessageFmt, | |||
| demoHelpStr, | |||
| docs.URL("sql-statements.html"), | |||
| docs.URL("use-the-built-in-sql-client.html"), | |||
| docs.URL("cockroach-sql.html"), | |||
There was a problem hiding this comment.
Not for this PR, but the link without the extension is preferred. The website automatically redirects from the page with .html to the one without.
mdlinville
added a commit
to cockroachdb/docs
that referenced
this pull request
Feb 8, 2024
* Extend redirect to more versions This link is used in the CLI help text. This redirect will be needed until the help text is updated in cockroachdb/cockroach#118960.
rafiss
approved these changes
Feb 8, 2024
|
TFTR! bors r+ |
lunevalex
added
backport-23.2.x
|
Since you are already backporting to 23.1, would you consider backporting to 22.2 in case we cut another release? |
|
Build succeeded: |
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL shell help function redirects the user to
use-the-built-in-sql-client.html this page no longer exists. Instead the SQL shell should point to cockroach-sql.html.
Epic: None
Release note (cli change): Change the SQL shell help URL to point to cockroach-sql.html.