pcr: delete physical_replication.enabled setting #119149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
requested review from
DarrylWong and
renatolabs
and removed request for
a team
stevendanna
reviewed
Feb 14, 2024
stevendanna
reviewed
Feb 14, 2024
Comment on lines
-400
to
-406
| .filter(option => canViewKvGraphs || !option.isKvDashboard) | ||
| // Don't show the replication dashboard if not enabled. | ||
| .filter( | ||
| option => | ||
| this.props.crossClusterReplicationEnabled || | ||
| option.label !== "Physical Cluster Replication", | ||
| ); |
There was a problem hiding this comment.
I think this is fine to always show this dashboard. If people don't like it, we can follow up with something that just sets a new feature flag if you happen to have > 1 tenant.
There was a problem hiding this comment.
I think hiding it was a private-preview thing; with it coming out of preview I don't think there is any precedent for keeping it optional/hidden.
stevendanna
approved these changes
Feb 15, 2024
|
TFTR! bors r+ |
|
Merge conflict. |
Release note: none. Epic: none.
Release note (enterprise change): Physical Cluster Replication is now always enabled, and the setting physical_replication.enabled has been removed.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (enterprise change): Physical Cluster Replication no longer requires toggling the setting
physical_replication.enabledto be used, and the setting has been removed.