Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql,*: align settings defaults for UA #119221

Merged
merged 6 commits into from
Feb 15, 2024
Merged

sql,*: align settings defaults for UA #119221

merged 6 commits into from
Feb 15, 2024

Commits on Feb 14, 2024

  1. sql: enable manual_range_split/scatter by default 

    This makes the out-of-the-box UA behavior match the pre-UA behavior.
For serverless / hosted MT deployments, we can configure the non-default
behavior accordingly.

Release note: none.
Epic: none.
    @dt
    dt committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    81c3825 View commit details
    Browse the repository at this point in the history

  2. server: disable trace.redact_at_virtual_cluster_boundary.enabled by d… 

    …efault

Today non-UA clusters see non-redacted traces. With this change, UA
clusters will as well out of the box, making the out-of-the-box UA
behavior match the pre-UA behavior. For hosted MT / serverless
deployment, we can override this ourselves to redact traces shown
to MT tenants.

Release note: none.
Epic: none.
    @dt
    dt committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e0386b5 View commit details
    Browse the repository at this point in the history

  3. sql: enable feature_access.zone_configs_unrestricted by default 

    Prior to UA, zone config operations worked out of the box. With this
change a UA cluster will also allow them out of the box without any
modification. In a serverless/MT deployment we can override this to
restrict secondary tenants.

Release note: none.
Epic: none.
    @dt
    dt committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    43c9b4d View commit details
    Browse the repository at this point in the history

  4. configprofiles: remove spanconfig.range_coalescing overrides 

    These didn't match their non-UA behavior of being default on.

Release note (enterprise change): clusters created to run PCR no longer automatically disable the spanconfig.range_coalescing settings.
Users who started using PCR on 23.1 or 23.2 may wish to manually reset these settings.

Epic: none.
    @dt
    dt committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ff5e66c View commit details
    Browse the repository at this point in the history

  5. sql: enable virtual_cluster.feature_access.multiregion.enabled by def… 

    …ault

Pre-UA this worked by default, and now in a UA cluster it will work by
default out of the box as well. For non-UA MT clusters where MR is not
supported, it can be overridden accordingly.

Release note: none.
Epic: none.
    @dt
    dt committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    f835400 View commit details
    Browse the repository at this point in the history

  6. sql: remove disable_drop_virtual_cluster 

    Other drop operations are gated only on safe updates, so this
one can be too.

Release note: none.
Epic: none.
    @dt
    dt committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fa939eb View commit details
    Browse the repository at this point in the history