Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: repopulate request body for webhook sink retries #119326

Merged

Commits on Feb 21, 2024

  1. changefeedccl: repopulate request body for webhook sink retries

    The webhook sink reuses an http request for retries. However, the http
    library consumes the request body, so retries may result in an error due
    to a non-zero content length but zero length body. This change
    re-initializes the http request body on every request so that it will
    have the right contents on every retry.
    
    Epic: none
    Fixes: cockroachdb#118485
    
    Release note (bug fix): Fixes a bug in the webhook sink where the
    http request body may not be initialized on retries, resulting in the
    error "http: ContentLength=... with Body length 0".
    rharding6373 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7ade4de View commit details
    Browse the repository at this point in the history