Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: increment txn.restarts.writetooold on WriteTooOld error #119411

Merged
merged 1 commit into from
Feb 20, 2024

Commits on Feb 20, 2024

  1. kv: increment txn.restarts.writetooold on WriteTooOld error

    WriteTooOld errors were previously counted in either the
    `txn.restarts.writetooold` metric or the `txn.restarts.writetoooldmulti` metric,
    depending on when in the lifecycle of a transaction they were thrown. Now that
    WriteTooOld errors are rarely (never?) deferred, we would like to consolidate
    these metrics to avoid confusion.
    
    As a first step, we now increment `txn.restarts.writetooold` in both cases. In
    the next release, we can remove the `txn.restarts.writetoooldmulti` metric and
    its presence in the "Transaction Restarts" graph in the SQL Dashboard.
    
    Release note (ui change): The "Write Too Old" metric in the "Transaction Restarts"
    graph under the SQL Dashboard now includes all restarts previously categorized as
    "Write Too Old (multiple)". The former is a now a superset of the latter. The
    "Write Too Old (multiple)" metric will be removed in a future release.
    nvanbenschoten committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f61838f View commit details
    Browse the repository at this point in the history