Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: changefeedccl: repopulate request body for webhook sink retries #119495

Merged
merged 1 commit into from Feb 23, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 22, 2024

Backport 1/1 commits from #119326 on behalf of @rharding6373.

/cc @cockroachdb/release


The webhook sink reuses an http request for retries. However, the http library consumes the request body, so retries may result in an error due to a non-zero content length but zero length body. This change re-initializes the http request body on every request so that it will have the right contents on every retry.

Epic: none
Fixes: #118485

Release note (bug fix): Fixes a bug in the webhook sink where the http request body may not be initialized on retries, resulting in the error "http: ContentLength=... with Body length 0".


Release justification: Fixes a bug in the webhook sink that can result in no request body after certain retryable errors.

The webhook sink reuses an http request for retries. However, the http
library consumes the request body, so retries may result in an error due
to a non-zero content length but zero length body. This change
re-initializes the http request body on every request so that it will
have the right contents on every retry.

Epic: none
Fixes: #118485

Release note (bug fix): Fixes a bug in the webhook sink where the
http request body may not be initialized on retries, resulting in the
error "http: ContentLength=... with Body length 0".
@blathers-crl blathers-crl bot requested a review from a team as a code owner February 22, 2024 01:38
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-119326 branch from 52d85db to 6726666 Compare February 22, 2024 01:38
@blathers-crl blathers-crl bot requested review from jayshrivastava and removed request for a team February 22, 2024 01:38
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 22, 2024
Copy link
Author

blathers-crl bot commented Feb 22, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 22, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rharding6373 rharding6373 merged commit 61b6c73 into release-23.1 Feb 23, 2024
6 checks passed
@rharding6373 rharding6373 deleted the blathers/backport-release-23.1-119326 branch February 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants