Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt/execbuilder: fix EXPORT when input expression has hidden columns #119538

Merged
merged 2 commits into from Feb 27, 2024

Conversation

mgartner
Copy link
Collaborator

opt/execbuilder: fix EXPORT when input expression has hidden columns

Fixes #115290

Release note (bug fix): A bug has been fixed that caused internal errors
when executing EXPORT statement.

opt/execbuilder: remove getNodeColumnOrdinalSet

This simple function was only used in one place, so it has been inlined
and removed.

Release note: None

@mgartner mgartner requested a review from a team as a code owner February 22, 2024 20:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: nice!

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @yuzefovich)

@rytaft
Copy link
Collaborator

rytaft commented Feb 22, 2024

Probably worth backporting this too, right?

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @yuzefovich)

@mgartner mgartner added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Feb 27, 2024
@mgartner
Copy link
Collaborator Author

Probably worth backporting this too, right?

Yes - added the labels.

Fixes cockroachdb#115290

Release note (bug fix): A bug has been fixed that caused internal errors
when executing EXPORT statement.
This simple function was only used in one place, so it has been inlined
and removed.

Release note: None
@mgartner
Copy link
Collaborator Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 27, 2024

Build succeeded:

@craig craig bot merged commit 3d07982 into cockroachdb:master Feb 27, 2024
15 checks passed
Copy link

blathers-crl bot commented Feb 27, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 592272c to blathers/backport-release-23.1-119538: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from 592272c to blathers/backport-release-23.2-119538: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: v23.1.11: column 1 not in input with Export
4 participants