New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt/execbuilder: fix EXPORT when input expression has hidden columns #119538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @yuzefovich)
Probably worth backporting this too, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @yuzefovich)
Yes - added the labels. |
Fixes cockroachdb#115290 Release note (bug fix): A bug has been fixed that caused internal errors when executing EXPORT statement.
This simple function was only used in one place, so it has been inlined and removed. Release note: None
a18c765
to
213b6d1
Compare
TFTRs! bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 592272c to blathers/backport-release-23.1-119538: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. error creating merge commit from 592272c to blathers/backport-release-23.2-119538: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
opt/execbuilder: fix EXPORT when input expression has hidden columns
Fixes #115290
Release note (bug fix): A bug has been fixed that caused internal errors
when executing EXPORT statement.
opt/execbuilder: remove getNodeColumnOrdinalSet
This simple function was only used in one place, so it has been inlined
and removed.
Release note: None