Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql, opt: support index hints for insert and upsert #119600

Merged
merged 2 commits into from Feb 27, 2024

Conversation

rytaft
Copy link
Collaborator

@rytaft rytaft commented Feb 23, 2024

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release


Release justification: low risk change to empower a customer to avoid bad query plans

@rytaft rytaft requested review from a team as code owners February 23, 2024 22:20
Copy link

blathers-crl bot commented Feb 23, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 23, 2024
Copy link

blathers-crl bot commented Feb 23, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rytaft rytaft requested a review from rafiss February 23, 2024 22:28
Fixes cockroachdb#98211

Release note (sql change): Added support for index hints with INSERT
and UPSERT statements. This allows INSERT ... ON CONFLICT and UPSERT
queries to use index hints in the same way they are already supported
for UPDATE and DELETE statements.
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Don't forgot to post to the Slack backports channel.

Reviewed 12 of 12 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @rafiss)

@rytaft
Copy link
Collaborator Author

rytaft commented Feb 27, 2024

Thanks! I just pinged you on the slack thread

@rytaft rytaft requested review from rharding6373 and removed request for rafiss February 27, 2024 01:43
@rytaft rytaft merged commit e38b7be into cockroachdb:release-23.1 Feb 27, 2024
6 checks passed
@rytaft rytaft deleted the backport23.1-119104-119597 branch February 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants