sql: add ttl_disable_changefeed_replication table storage parameter #119611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andyyang890
force-pushed
the
ttl_disable_changefeed
branch
3 times, most recently
from
2ebd2a1
to
b587822
Compare
andyyang890
requested review from
srosenberg and
DarrylWong
and removed request for
a team
annrpom
reviewed
Feb 26, 2024
There was a problem hiding this comment.
LGTM!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong, @rafiss, @rharding6373, and @srosenberg)
annrpom
approved these changes
Feb 26, 2024
rharding6373
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/cdc_filtering.go line 360 at r1 (raw file):
require.NoError(t, err) case ttlFilteringTableStorageParam: t.Status("set ttl_disable_changefeed_replication")
nit: Could you add the table name to the status?
andyyang890
force-pushed
the
ttl_disable_changefeed
branch
2 times, most recently
from
bdb224b
to
97c6ed9
Compare
This patch adds a new `ttl_disable_changefeed_replication` table storage parameter, which can be used to disable changefeed replication for row-level TTL on a per-table basis. Release note (sql change): A new `ttl_disable_changefeed_replication` table storage parameter has been added and can be used to disable changefeed replication for row-level TTL on a per-table basis.
andyyang890
force-pushed
the
ttl_disable_changefeed
branch
from
97c6ed9
to
970ea32
Compare
|
TFTRs! bors r=annrpom,rharding6373 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new
ttl_disable_changefeed_replicationtablestorage parameter, which can be used to disable changefeed replication
for row-level TTL on a per-table basis.
Fixes #118849
Release note (sql change): A new
ttl_disable_changefeed_replicationtable storage parameter has been added and can be used to disable
changefeed replication for row-level TTL on a per-table basis.