systemschema: use ExcludeDataFromBackup on some tables #119947
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
force-pushed
the
system-table-exclude-from-backup
branch
4 times, most recently
from
b9d27cc
to
de39d70
Compare
|
Hey @rafiss, |
|
It cannot be backported, since modifying system tables in this way is not possible in patch releases. |
There was a problem hiding this comment.
Looks good, just one minor comment
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
pkg/upgrade/upgrades/v24_1_system_database.go line 111 at r1 (raw file):
if err := deps.DB.DescsTxn(ctx, func(ctx context.Context, txn descs.Txn) error { for _, tabName := range []catconstants.SystemTableName{ catconstants.ReplicationConstraintStatsTableName,
Do we want an upgrade test to confirm this?
Certain tables are updated frequently and contain data that should never be backed up or restored. Allowing backups on them is not desired, since that results in protected timestamps being applied on the table, which prevents GC of old data. This commit excludes the lease, replication_constraint_stats, replication_stats, and tenant_usage tables from backups. These are the tables that explicitly have their gc.ttl configured to a lower value. Release note: None
rafiss
force-pushed
the
system-table-exclude-from-backup
branch
from
de39d70
to
3d87bec
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/upgrade/upgrades/v24_1_system_database.go line 111 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Do we want an upgrade test to confirm this?
i added a logic test
There was a problem hiding this comment.
Reviewed 2 of 4 files at r2, all commit messages.
Reviewable status:
|
tftr! bors r+ |
|
Build succeeded: |
Certain tables are updated frequently and contain data that should never be backed up or restored. Allowing backups on them is not desired, since that results in protected timestamps being applied on the table, which prevents GC of old data.
This commit excludes the lease, replication_constraint_stats, replication_stats, and tenant_usage tables from backups. These are the tables that explicitly have their gc.ttl configured to a lower value.
informs: #80866
Release note: None