catalog: remove outdated CHECK post-deserialization changes #120008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
changed the title
rafiss
added
backport-23.2.x
annrpom
approved these changes
Mar 7, 2024
| @@ -3598,3 +3598,34 @@ CREATE UNIQUE INDEX ON public.t_118626(c) WHERE n>= 1; | |||
|
|
|||
| statement ok | |||
| ALTER TABLE public.t_118626 ALTER PRIMARY KEY USING COLUMNS(b); | |||
|
|
|||
| # Regression test to make sure that we can drop and re-add a CHECK constraint | |||
There was a problem hiding this comment.
Looks like the legacy schema changer doesn't like this test - are we able to specify "do this only in dsc land" in logic tests?
There was a problem hiding this comment.
there is! i have now added a skip directive here for the legacy schema changer
|
changes to backupccl look fine! |
This post-deserialization changes is vestigial. It is no longer needed since during the upgrade to 23.2, all descriptors had changes applied. The maybeAddConstraintIDs change had a bug that caused it to clobber the mutation of an in-progress schema change. Luckily we can just remove the change entirely rather than fixing it. Release note (bug fix): Fixed a bug that occurred when using ALTER TABLE to drop and re-add a CHECK constraint with the same name.
|
tftr! bors r+ |
|
Build succeeded: |
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This post-deserialization changes is vestigial. It is no longer
needed since during the upgrade to 23.2, all descriptors had changes
applied.
The maybeAddConstraintIDs change had a bug that caused it to clobber the
mutation of an in-progress schema change. Luckily we can just remove the
change entirely rather than fixing it.
fixes #120017
Release note (bug fix): Fixed a bug that occurred when using ALTER TABLE
to drop and re-add a CHECK constraint with the same name.