sql: crdb_internal.leases should be placed behind VIEWCLUSTERMETADATA #120014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all users could access the internal table crdb_internal.leases. This was unnecessary, as the table's intensive locking requirements can potentially cause heavy overhead. Limiting user access to the VIEWCLUSTERMETADATA privilege is a more sensible approach. This patch will place crdb_internal.leases behind the VIEWCLUSTERMETADATA privilege, which would also help mitigate previous issues (cockroachdb#119253). Fixes: cockroachdb#119440 Release note (sql change): crdb_internal.leases is now behind the VIEWCLUSTERMETADATA privilege.
|
This change is |
|
@annrpom TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all users could access the internal table crdb_internal.leases. This was unnecessary, as the table's intensive locking requirements can potentially cause heavy overhead. Limiting user access to the VIEWCLUSTERMETADATA privilege is a more sensible approach. This patch will place crdb_internal.leases behind the VIEWCLUSTERMETADATA privilege, which would also help mitigate previous issues (#119253).
Fixes: #119440
Release note (sql change): crdb_internal.leases is now behind the VIEWCLUSTERMETADATA privilege.