Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove default_target_cluster.check_service.enabled #120080

Merged
merged 1 commit into from Mar 12, 2024

Conversation

dt
Copy link
Member

@dt dt commented Mar 7, 2024

Release note (enterprise change): default_target_cluster can now be set to any tenant name by default, including a tenant yet to be created or have service started.
Epic: none.

@dt dt requested a review from stevendanna March 7, 2024 21:23
@dt dt requested a review from a team as a code owner March 7, 2024 21:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you might need to update some import statements in pkg/sq/tenant_update.go but other than that this looks good.

Release note (enterprise change): default_target_cluster can now be set to any tenant name by default, including a tenant yet to be created or have service started.
Epic: none.
@dt
Copy link
Member Author

dt commented Mar 12, 2024

update some import statements in pkg/sq/tenant_update.go

Done.

@dt
Copy link
Member Author

dt commented Mar 12, 2024

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 12, 2024

This PR was included in a batch that was canceled, it will be automatically retried

@craig craig bot merged commit 9adee4e into cockroachdb:master Mar 12, 2024
19 checks passed
@craig
Copy link
Contributor

craig bot commented Mar 12, 2024

Build succeeded:

@dt dt deleted the svc-check branch March 19, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants