New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: cluster-ui, db-console: fix bug where store ids are treated as node ids #120234
release-23.1: cluster-ui, db-console: fix bug where store ids are treated as node ids #120234
Conversation
Previously, store ids were being treated as node ids on the databases view. This resulted in "Regions/Nodes" column showing inaccurate information in some cases. Now, store ids are mapped to node ids on the databases view which resolves the issue. Also, a log message is skipped during tests so that the output isn't polluted with expected warnings. Fixes: cockroachdb#118957 Release note (ui change): Resolves an issue where clusters with multiple stores per node may list inaccurate region/node information in the databases table.
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not really able to give the typescript code a proper review, but a process question: does this also need to be backported to the 23.2 branch?
TFTRs! |
Backport 1/1 commits from #119260.
/cc @cockroachdb/release
Previously, store ids were being treated as node ids on the databases view. This resulted in "Regions/Nodes" column showing inaccurate information in some cases. Now, store ids are mapped to node ids on the databases view which resolves the issue.
Fixes: #118957
Release note (ui change): Resolves an issue where clusters with multiple stores per node may list inaccurate region/node information in the databases table.
Release justification: Without this fix, customers with multiple stores per node may see inaccurate information in the databases table.