backupccl: clear InProgressImportStartTime in RESTORE #120414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, RESTORE elides data from the in-progress import using MVCC timestamps and the stored InProgressImportStartTime, effectively restoring the table to the pre-import state. However, we were failing to clear the descriptor field when bringing the tables back online. As a result, a subsequent backup and restore of that table would end up eliding data from the online table. Epic: none Release note (bug fix): Fixes an issue in which a RESTORE of a backup that itself contained a table created by the RESTORE of a table with an in-progress IMPORT would fail to restore all rows.
|
This change is |
msbutler
approved these changes
Mar 13, 2024
stevendanna
added
backport-23.1.x
|
bors r=msbutler |
|
Build succeeded: |
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, RESTORE elides data from the in-progress import using MVCC timestamps and the stored InProgressImportStartTime, effectively restoring the table to the pre-import state.
However, we were failing to clear the descriptor field when bringing the tables back online. As a result, a subsequent backup and restore of that table would end up eliding data from the online table.
Epic: none
Release note (bug fix): Fixes an issue in which a RESTORE of a backup that itself contained a table created by the RESTORE of a table with an in-progress IMPORT would fail to restore all rows.