roachtest: limit payload sizes in backup-restore/mixed-version #120462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
This change is |
dt
added
backport-23.1.x
renatolabs
reviewed
Mar 14, 2024
| if bankRows < 1000 { | ||
| possiblePayloads = []int{16, 64} | ||
| } | ||
| bankPayload := possiblePayloads[testRNG.Intn(len(bankPossiblePayloadBytes))] |
Previously it could randomly choose to revise only 100 rows with 16kb payloads in every revision. While this usually works when run on 512mb ranges, it can flake when run on 64mb ranges as that many large revisions exceeds the range's capacity. Release note: none. Epic: none.
msbutler
approved these changes
Mar 25, 2024
|
TFTR! bors r+ |
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it could randomly choose to revise only 100 rows with 16kb payloads in every revision. While this usually works when run on 512mb ranges, it can flake when run on 64mb ranges as that many large revisions exceeds the range's capacity.
Release note: none.
Epic: none.