Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show license expiration alert in Db Console #120490

Merged
merged 1 commit into from Mar 15, 2024

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Mar 14, 2024

With this change, new alert message is shown in Db Console when license is expired or less than 15 days left before it will expire.
This change doesn't affect clusters that doesn't have any license set.

Release note (ui change): show alert message in Db Console when license is expired or close to expire.

Depends on: #120475

Resolves: #98589

Epic: None

Screens:

  1. Less than 15 days before license expires
Screenshot 2024-03-14 at 13 26 18 2. License expired Screenshot 2024-03-14 at 13 25 26 3. License expired today Screenshot 2024-03-14 at 13 25 59

@koorosh koorosh requested a review from a team as a code owner March 14, 2024 12:03
Copy link

blathers-crl bot commented Mar 14, 2024

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Mar 14, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh
Copy link
Collaborator Author

koorosh commented Mar 14, 2024

cc @innabs , lmk if text of alerts of visual representation should be changed. Currently, default alerts are used.

Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @abarganier, @koorosh, and @xinhaoz)


-- commits line 11 at r1:
nit: include the days to expiry threshold in the release note.


pkg/ui/workspaces/db-console/src/redux/alerts.ts line 700 at r1 (raw file):

      default:
        return "None";
    }

maybe better as a map?

@koorosh koorosh force-pushed the ui-license-expiration-alert-msg branch from cd24026 to 11d50c2 Compare March 15, 2024 10:33
Copy link

blathers-crl bot commented Mar 15, 2024

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link
Collaborator Author

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @abarganier, @dhartunian, and @xinhaoz)


-- commits line 11 at r1:

Previously, dhartunian (David Hartunian) wrote…

nit: include the days to expiry threshold in the release note.

Done.


pkg/ui/workspaces/db-console/src/redux/alerts.ts line 700 at r1 (raw file):

Previously, dhartunian (David Hartunian) wrote…

maybe better as a map?

Done.

@koorosh koorosh force-pushed the ui-license-expiration-alert-msg branch 2 times, most recently from f003b92 to 7542fb0 Compare March 15, 2024 12:19
With this change, new alert message is shown in Db Console
when license is expired or less than 15 days left before
it will expire.
This change doesn't affect clusters that doesn't have
any license set.

Release note (ui change): show alert message in Db Console
when license is expired or less than 15 days left before
it expires.
@koorosh koorosh force-pushed the ui-license-expiration-alert-msg branch from 7542fb0 to 006838d Compare March 15, 2024 14:40
@koorosh
Copy link
Collaborator Author

koorosh commented Mar 15, 2024

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 15, 2024

@craig craig bot merged commit 1a6e93c into cockroachdb:master Mar 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

observability: show license expiry date in DB Console
3 participants