sql/schemachanger: avoid generating event logs during EXPLAIN (DDL) #120563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @fqazi)
pkg/sql/schemachanger/scbuild/event_log.go line 57 at r1 (raw file):
} func logEvents(
nit: should this be renamed to something like makeEventLogCallback
Previously, the declarative schema changer could generate event log entries even when DDL was only being explained. This created a misleading impression that schema changes had been executed. This patch modifies the declarative schema changer to prevent instant logging of events. Instead, it returns a callback that can be executed before the statement phase. Fixes: cockroachdb#118897 Release note (bug fix): EXPLAIN (DDL) would generate event log entries for schema changes even though they weren't executed.
|
@rafiss TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the declarative schema changer could generate event log entries even when DDL was only being explained. This created a misleading impression that schema changes had been executed. This patch modifies the declarative schema changer to prevent instant logging of events. Instead, it returns a callback that can be executed before the statement phase.
Fixes: #118897
Release note (bug fix): EXPLAIN (DDL) would generate event log entries for schema changes even though they weren't executed.