server: include WAL failover path within the stores status #120677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbowens
requested review from
RaduBerinde and
abarganier
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
RaduBerinde
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @abarganier)
jbowens
force-pushed
the
status-failover-path
branch
from
c443281
to
4408392
Compare
Expand the response from the /_status/stores endpoint to include the store's data directory and the path to the configured WAL failover secondary if configured. Close cockroachdb#119795. Epic: CRDB-35401 Release note (ops change): Adds node ID, dir and wal_failover_path fields to the /_status/stores endpoint.
jbowens
force-pushed
the
status-failover-path
branch
from
4408392
to
857d4d1
Compare
|
TFTR! bors r=RaduBerinde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the response from the /_status/stores endpoint to include the store's data directory and the path to the configured WAL failover secondary if configured.
Close #119795.
Epic: CRDB-35401
Release note: Adds a new field to the stores