cli,server: add --virtualized[-empty] flags to init #120813
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
stevendanna
requested review from
dt
and removed request for
a team and
abarganier
| } | ||
|
|
||
| initAttempt := func() error { | ||
| const defaultApplicationClusterName = "application" |
There was a problem hiding this comment.
bikeshed: we can't use default since it doesn't work as a bare keyword in places where we use a tenant name, but is there anything shorter we could use?
pkg/server/server.go
Outdated
| } | ||
| return nil | ||
| } | ||
| return errors.Errorf("cluster initialization failed. cluster may need to be manually configured") |
There was a problem hiding this comment.
ultra minor nit: maybe a ; or : separator to avoid the question of capitalizing cluster
pkg/server/serverpb/init.proto
Outdated
| } | ||
|
|
||
| enum InitType { | ||
| NO_INIT = 0; |
There was a problem hiding this comment.
nit: maybe make this DEFAULT and then add NONE as a separate option, even if the switch maps them both to the same thing for now?
ultra-nit: wise I'd leave "init" out of the value names, since it'll be in the prefix of the generated name.
stevendanna
force-pushed
the
ssd/init-flags
branch
from
96cf9b4
to
7d6e4b0
Compare
This adds the ability to specify that the cluster should be initialized as a virtualized cluster. Currently, this runs a one-time set of SQL initialization steps. One may rightly ask why we don't run the SQL directly from the `init` command. Running the SQL command would 1) Require that the user pass new custom-flags to init if they are using on-standard listen options, and 2) Technically may race with the server startup unless we waiting until the server was listening for connections. Fixes cockroachdb#120262 Release note (ops change): Cluster virtualization is now configured at cluster startup via flags (--virtualized or --virtualized-empty) passed to `cocroach init` rather than via the previously available --config-profile flag passed to `cockroach start`.
stevendanna
force-pushed
the
ssd/init-flags
branch
from
7d6e4b0
to
532c95d
Compare
|
Added a test. |
|
bors r=dt |
This adds the ability to specify that the cluster should be initialized as a virtualized cluster.
Currently, this runs a one-time set of SQL initialization steps.
One may rightly ask why we don't run the SQL directly from the
initcommand. Running the SQL command wouldRequire that the user pass new custom-flags to init if they are
using on-standard listen options, and
Technically may race with the server startup unless we waiting
until the server was listening for connections.
Fixes #120262
Release note (ops change): Cluster virtualization is now configured at cluster startup via flags (--virtualized or --virtualized-empty) passed to
cocroach initrather than via the previously available --config-profile flag passed tocockroach start.