admission: remove DiskName from StoreSpec.ProvisionedRateSpec

[CheranMahalingam]

This commit cleans up changes from #119885. There is no longer a need for users to specify a disk name when specifying the provisioned bandwidth since we can now automatically infer disk names from the StoreSpec.Path and the underlying block device.

Informs: #86857.

Epic: None.
Release note (ops change): The provisioned-rate field, if specified, should no longer accept a disk-name or an optional bandwidth field. To use the disk bandwidth constraint the store-spec must contain provisioned-rate=bandwidth=<bandwidth-bytes/s>, otherwise the cluster setting kv.store.admission.provisioned_bandwidth will be used.

[cockroach-teamcity]

This change is 

[CheranMahalingam]

Reviewable status: complete! 0 of 0 LGTMs obtained

---

pkg/base/store_spec.go line 167 at r1 (raw file):

type ProvisionedRateSpec struct {
	// ProvisionedBandwidth is the bandwidth provisioned for this store in bytes/s.
	ProvisionedBandwidth int64

Optionally, the ProvisionedBandwidth could be moved out of this struct since it is now the only field. I have left it as is because I am unsure of whether AC will ever extend this struct to include additional options (i.e. read or write bandwidth).

---

pkg/base/store_spec.go line 309 at r1 (raw file):

//   - 0.2             -> 20% of the available space
//   - attrs=xxx:yyy:zzz A colon separated list of optional attributes.
//   - provisioned-rate=<bandwidth-bytes/s> The provisioned-rate can be used for

Optionally, it makes sense to rename provisioned-rate to provisioned-bandwidth but I have left it as is to avoid confusion for any users that already use provisioned-rate.

[sumeerbhola]

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @aadityasondhi and @CheranMahalingam)

---

pkg/base/store_spec.go line 167 at r1 (raw file):

Previously, CheranMahalingam wrote…

Optionally, the ProvisionedBandwidth could be moved out of this struct since it is now the only field. I have left it as is because I am unsure of whether AC will ever extend this struct to include additional options (i.e. read or write bandwidth).

struct is fine for now. We'll probably extend it to include IOPS in the future. In that sense "rate" (in ProvisionedRateSpec) is also an ok-ish term since it doesn't specify whether the rate is bandwidth or IOPS or ...

---

pkg/base/store_spec.go line 309 at r1 (raw file):

Previously, CheranMahalingam wrote…

Optionally, it makes sense to rename provisioned-rate to provisioned-bandwidth but I have left it as is to avoid confusion for any users that already use provisioned-rate.

Let's make this "provisioned-rate=bandwidth=<bandwidth-bytes/s>

---

pkg/base/store_spec.go line 309 at r2 (raw file):

//   - 0.2             -> 20% of the available space
//   - attrs=xxx:yyy:zzz A colon separated list of optional attributes.
//   - provisioned-rate=<bandwidth-bytes/s> The provisioned-rate can be used for

since we've made it easier to configure disk bandwidth tokens for AC, we've also made it easier to accidentally turn it on. Can you add a comment in

cockroach/pkg/kv/kvserver/kvadmission/kvadmission.go

Lines 99 to 106 in d0c3317

	// ProvisionedBandwidth set a value of the provisioned
	// bandwidth for each store in the cluster.
	var ProvisionedBandwidth = settings.RegisterByteSizeSetting(
	settings.SystemOnly, "kvadmission.store.provisioned_bandwidth",
	"if set to a non-zero value, this is used as the provisioned bandwidth (in bytes/s), "+
	"for each store. It can be over-ridden on a per-store basis using the --store flag",
	0,
	settings.WithPublic)

that setting kvadmission.store.provisioned_bandwidth to a positive value will enable disk bandwidth based admission control, since admission.disk_bandwidth_tokens.elastic.enabled defaults to true.

[CheranMahalingam]

TFTR!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @aadityasondhi and @sumeerbhola)

---

pkg/base/store_spec.go line 309 at r2 (raw file):

Previously, sumeerbhola wrote…

since we've made it easier to configure disk bandwidth tokens for AC, we've also made it easier to accidentally turn it on. Can you add a comment in

cockroach/pkg/kv/kvserver/kvadmission/kvadmission.go

Lines 99 to 106 in d0c3317

	// ProvisionedBandwidth set a value of the provisioned
	// bandwidth for each store in the cluster.
	var ProvisionedBandwidth = settings.RegisterByteSizeSetting(
	settings.SystemOnly, "kvadmission.store.provisioned_bandwidth",
	"if set to a non-zero value, this is used as the provisioned bandwidth (in bytes/s), "+
	"for each store. It can be over-ridden on a per-store basis using the --store flag",
	0,
	settings.WithPublic)

that setting kvadmission.store.provisioned_bandwidth to a positive value will enable disk bandwidth based admission control, since admission.disk_bandwidth_tokens.elastic.enabled defaults to true.

Done.

[sumeerbhola]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)

[CheranMahalingam]

bors r=sumeerbhola

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)
• check_generated_code
• docker_image_amd64
• examples_orms
• macos_amd64_build
• macos_arm64_build
• windows_build