Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engineccl: Fix data key generation for v2 encryption #121111

Merged
merged 3 commits into from
Mar 28, 2024
Merged

engineccl: Fix data key generation for v2 encryption #121111

merged 3 commits into from
Mar 28, 2024

Commits on Mar 28, 2024

  1. baseccl: Support * in --enterprise-encryption=path= 

    Matching the path between --store and --enterprise-encryption is difficult in
roachtests, and may be difficult in other orchestration frameworks as well.
Customizing keys on a per-store basis is rarely necessary so a wildcard can
sidestep this difficulty.

Updates cockroachdb#110123
Release note (cli change): The `--enterprise-encryption` flag now accepts the
special value `path=*` to apply the specified keys to all stores.
    @bdarnell
    bdarnell committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c28722e View commit details
    Browse the repository at this point in the history

  2. engineccl: Fix data key generation for v2 encryption 

    Prior tests of v2 encryption were too low-level and did not cover the data key
generation. The new roachtest provides end-to-end coverage.

This fixes a bug in not-yet-released functionality

Epic: none
Release note: none
    @bdarnell
    bdarnell committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c222868 View commit details
    Browse the repository at this point in the history

  3. cliflagsccl: Remove obsolete encryption key details 

    The key format is changing so defer to "gen encryption-key" instead of details
of the v1 key format.

Epic: none
Release note: None
    @bdarnell
    bdarnell committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6086f5f View commit details
    Browse the repository at this point in the history