roachtest: deflake admission-control/multitenant-fairness #121120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadityasondhi
requested review from
a team and
xinhaoz
and removed request for
a team
aadityasondhi
requested review from
srosenberg and
DarrylWong
and removed request for
a team
|
This change is |
aadityasondhi
force-pushed
the
20240326.deflake-admission-fairness-roachtest
branch
from
229be63
to
c7c769a
Compare
In cockroachdb#120236, we removed the `failed` metadata from the `crdb_internal.statement_statistics` table. Fixes cockroachdb#120586. Fixes cockroachdb#120587. Fixes cockroachdb#120588. Fixes cockroachdb#120589. Release note: None
aadityasondhi
force-pushed
the
20240326.deflake-admission-fairness-roachtest
branch
from
c7c769a
to
137f623
Compare
sumeerbhola
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @srosenberg, and @xinhaoz)
aadityasondhi
commented
Mar 26, 2024
There was a problem hiding this comment.
TFTR!
bors r=sumeerbhola
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #120236, we removed the
failedmetadata from thecrdb_internal.statement_statisticstable.Fixes #120586.
Fixes #120587.
Fixes #120588.
Fixes #120589.
Release note: None