opt: push Offset into IndexJoin #121160
opt: push Offset into IndexJoin #121160
Conversation
mgartner
requested review from
rytaft and
DrewKimball
and removed request for
a team
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball, @mgartner, and @rytaft)
pkg/sql/opt/xform/testdata/rules/limit line 896 at r1 (raw file):
└── 5 # Ensure that the limit is not pushed down when using SKIP LOCKED.
Glad you have this case!
mgartner
force-pushed
the
121157-push-offset-into-index-join
branch
from
bd5af74
to
6a8308d
Compare
The `PushOffsetIntoIndexJoin` rule has been added that pushes Offset expressions below IndexJoin expressions. It is very similar to `PushLimitIntoIndexJoin`. Fixes cockroachdb#121157 Release note (performance improvement): The optimizer now generates more efficient query plans for some queries with `OFFSET` clauses.
mgartner
force-pushed
the
121157-push-offset-into-index-join
branch
from
6a8308d
to
1e4be65
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
|
TFTRs! bors r+ |
|
We typically don't backport things that can change query plans unless they are disabled by default. I'm not inclined to go through that effort unless there's a strong need for it. |
|
@yuzefovich I take that back. We've seen some users run into this on v23.2, so I'll backport this behind a session setting. |
The
PushOffsetIntoIndexJoinrule has been added that pushes Offsetexpressions below IndexJoin expressions. It is very similar to
PushLimitIntoIndexJoin.Fixes #121157
Release note (performance improvement): The optimizer now generates more
efficient query plans for some queries with
OFFSETclauses.