Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt/memo: fix optimizer_use_virtual_computed_column_stats #121171

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

michae2
Copy link
Collaborator

@michae2 michae2 commented Mar 27, 2024

With optimizer_use_virtual_computed_column_stats set to false, constrained scans were still sometimes using stats on virtual computed columns. This commit adds a check to makeTableStatistics which prevents creation of any statistics referencing a virtual computed column, which is a stronger check than existed before.

With this check, the VirtualCols sets will always be empty when optimizer_use_virtual_computed_column_stats is false.

Informs: #68254

Epic: CRDB-8949

Release note: None

With optimizer_use_virtual_computed_column_stats set to false,
constrained scans were still sometimes using stats on virtual computed
columns. This commit adds a check to makeTableStatistics which prevents
creation of any statistics referencing a virtual computed column, which
is a stronger check than existed before.

With this check, the VirtualCols sets will always be empty when
optimizer_use_virtual_computed_column_stats is false.

Informs: cockroachdb#68254

Epic: CRDB-8949

Release note: None
@michae2 michae2 requested a review from a team as a code owner March 27, 2024 04:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@michae2 michae2 added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Mar 27, 2024
Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@michae2
Copy link
Collaborator Author

michae2 commented Mar 27, 2024

TFTR!

bors r=DrewKimball

@craig
Copy link
Contributor

craig bot commented Mar 27, 2024

Build failed (retrying...):

@craig craig bot merged commit 6b662e3 into cockroachdb:master Mar 27, 2024
22 checks passed
Copy link

blathers-crl bot commented Mar 27, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 579d42e to blathers/backport-release-23.1-121171: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from 579d42e to blathers/backport-release-23.2-121171: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants