Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: wrap error when parsing DN #121212

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 27, 2024

Epic: CRDB-34126
Release note: None

@rafiss rafiss requested review from bdarnell, fqazi, souravcrl and a team March 27, 2024 14:17
@rafiss rafiss requested review from a team as code owners March 27, 2024 14:17
Copy link

blathers-crl bot commented Mar 27, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bdarnell and @souravcrl)

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafiss
Copy link
Collaborator Author

rafiss commented Mar 27, 2024

tftr!

bors r+

@craig craig bot merged commit 87ed0b2 into cockroachdb:master Mar 27, 2024
22 checks passed
@rafiss rafiss deleted the fix-err-wrap branch March 29, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants