jobs: deflake TestRegistryLifecycle #121250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#116844 we added a CREATE USER statement to this tests setup. That statement produces 2 schema change jobs that could race with the coordination required for the assertions in this test to be valid. Here we solve this by only running the AfterJobStateMachine callback for the job we care about. Fixes cockroachdb#121149 Release note: None
|
This change is |
dt
approved these changes
Mar 28, 2024
|
bors r=dt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #116844 we added a CREATE USER statement to this tests setup. That statement produces 2 schema change jobs that could race with the coordination required for the assertions in this test to be valid.
Here we solve this by only running the AfterJobStateMachine callback for the job we care about.
Fixes #121149
Release note: None