Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update version of job compat mixed-version roachtest #121296

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Mar 28, 2024

This patch updates the job compat roachtest to
declarative_schema_changer/job-compatibility-mixed-version-V232-V241.

Epic: CRDB-35306
Informs: #116395

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom annrpom force-pushed the mixed-version-job-compat branch 2 times, most recently from 05e19b3 to c3bae7e Compare April 2, 2024 15:08
@annrpom annrpom requested review from a team and rafiss April 2, 2024 18:29
@annrpom annrpom marked this pull request as ready for review April 2, 2024 18:29
@annrpom annrpom requested a review from a team as a code owner April 2, 2024 18:29
@annrpom annrpom requested review from herkolategan and DarrylWong and removed request for a team April 2, 2024 18:29
This patch updates the job compat roachtest to
declarative_schema_changer/job-compatibility-mixed-version-V232-V241.

Epic: CRDB-35306
Informs: cockroachdb#116395

Release note: None
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @herkolategan, and @rafiss)

@annrpom annrpom added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Apr 15, 2024
@annrpom
Copy link
Contributor Author

annrpom commented Apr 15, 2024

Still merging/backporting this change so that the test labels are as expected (i.e. we go from 23.1->23.2 compat to 23.2->24.1 compat to 24.1->24.2 compat instead of skipping 23.2->24.1)

@annrpom
Copy link
Contributor Author

annrpom commented Apr 15, 2024

TFTR! ('-')7

bors r=fqazi

@craig craig bot merged commit 83134d2 into cockroachdb:master Apr 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants