Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql: alter sequence options no min, no max and as type to replicate postgreSQL #121310

Merged
merged 1 commit into from Mar 29, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 28, 2024

Backport 1/1 commits from #120984 on behalf of @andrew-delph.

/cc @cockroachdb/release


This commit changes 'NO MINVALUE' and 'NO MAXVALUE' sequence options
to replicate postgreSQL behavior.
If the sequence is ascending then the NO MAXVALUE is the largest value
for it int type and NO MINVALUE is 1.
If the sequence is descending then the NO MAXVALUE is -1 and NO MINVALUE
is the smallest value for its int type.
This commit also addresses how MINVALUE and MAXVALUE are automatically
changed when altering the seq int type. If either is equal to the
current types limit, then it is will automatically adjsut to the
changes types limits. Otherwise it will not change.

Epic: None

Release note (bug fix): Sequence options for 'NO MINVALUE' and 'NO
MAXVALUE' now replicate postgreSQL.

Sequence MINVALUE and MAXVALUE automatical adjust to new types bounds
mirroring behavior of postgreSQL.


Release justification: bug fix

@blathers-crl blathers-crl bot requested a review from a team as a code owner March 28, 2024 22:05
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-120984 branch from 13e159e to 9d84f62 Compare March 28, 2024 22:05
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 28, 2024
Copy link
Author

blathers-crl bot commented Mar 28, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from rafiss March 28, 2024 22:05
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 28, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit changes 'NO MINVALUE' and 'NO MAXVALUE' sequence options
to replicate postgreSQL behavior.
If the sequence is ascending then the NO MAXVALUE is the largest value
for it int type and NO MINVALUE is 1.
If the sequence is descending then the NO MAXVALUE is -1 and NO MINVALUE
is the smallest value for its int type.
This commit also addresses how MINVALUE and MAXVALUE are automatically
changed when altering the seq int type. If either is equal to the
current types limit, then it is will automatically adjsut to the
changes types limits. Otherwise it will not change.

Release note (bug fix): Sequence options for 'NO MINVALUE' and 'NO
MAXVALUE' now replicate postgreSQL.

Sequence MINVALUE and MAXVALUE automatical adjust to new types bounds
mirroring behavior of postgreSQL.
@rafiss rafiss force-pushed the blathers/backport-release-24.1-120984 branch from 9d84f62 to 5566557 Compare March 29, 2024 15:56
@rafiss rafiss merged commit 5d952f8 into release-24.1 Mar 29, 2024
6 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.1-120984 branch March 29, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants