Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: workload/schemachange: support UDFs invoking other UDFs #121313

Merged
merged 2 commits into from Mar 29, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 28, 2024

Backport 2/2 commits from #121219 on behalf of @fqazi.

/cc @cockroachdb/release


This patch adds support for the schema change workload to create UDF's which invoke other UDF's, which will need the following:

  1. Extend pg_depend to support tracking UDF references to other UDFs. This is an extension from Postgres behaviour where classid will refer to the pg_proc table.
  2. Update the schema changer workload to create include UDF references when creating functions
  3. Modify the schema changer workload to ensure that DROP / RENAME FUNCTION operations on these functions check for references to other functions, which will cause the operation to fail.
  4. Modify the schema changer workload to ensure that DROP SCHEMA with the legacy schema changer will properly block operations if references exist from a different schema.

Fixes: #120671


Release justification: test change

Previously, we had no way of detecting UDF dependencies used by a UDF
making it hard to test / validate behaviour for the schema changer
workload. While Postgres does not track these dependencies, in CRDB we
are stricter enforcing them and will expose them inside pg_depend. To
address this, this patch will extend pg_depend to add dependencies from
one UDF to another.

Release note (sql change): extend pg_depend to include dependencies
between UDFs.
Previously, the randomized schema changer workload only created routines
that referred to types or tables. Since we added support for UDFs
calling other UDFs we need to add support. To address this, this patch
adds support for creating UDFs that can refer/invoke to other UDFs.

Fixes: #120671

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-121219 branch from ddc686e to 6def369 Compare March 28, 2024 23:15
@blathers-crl blathers-crl bot requested review from a team as code owners March 28, 2024 23:15
@blathers-crl blathers-crl bot requested review from DarrylWong and removed request for a team March 28, 2024 23:15
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Mar 28, 2024
@blathers-crl blathers-crl bot requested a review from renatolabs March 28, 2024 23:15
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Mar 28, 2024
Copy link
Author

blathers-crl bot commented Mar 28, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 28, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 557f4e6 into release-24.1 Mar 29, 2024
6 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.1-121219 branch March 29, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants