New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: workload/schemachange: support UDFs invoking other UDFs #121313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had no way of detecting UDF dependencies used by a UDF making it hard to test / validate behaviour for the schema changer workload. While Postgres does not track these dependencies, in CRDB we are stricter enforcing them and will expose them inside pg_depend. To address this, this patch will extend pg_depend to add dependencies from one UDF to another. Release note (sql change): extend pg_depend to include dependencies between UDFs.
Previously, the randomized schema changer workload only created routines that referred to types or tables. Since we added support for UDFs calling other UDFs we need to add support. To address this, this patch adds support for creating UDFs that can refer/invoke to other UDFs. Fixes: #120671 Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.1-121219
branch
from
March 28, 2024 23:15
ddc686e
to
6def369
Compare
blathers-crl
bot
requested review from
DarrylWong
and removed request for
a team
March 28, 2024 23:15
blathers-crl
bot
added
the
blathers-backport
This is a backport that Blathers created automatically.
label
Mar 28, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Mar 28, 2024
rafiss
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #121219 on behalf of @fqazi.
/cc @cockroachdb/release
This patch adds support for the schema change workload to create UDF's which invoke other UDF's, which will need the following:
Fixes: #120671
Release justification: test change