sql/schemachanger: add fallback for temp sequences #121379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, a statement like `CREATE TYPE geography` would cause an internal error. The legacy schema changer has an explicit check for this, which was not in the new schema changer. Release note: None
The new schema changer doesn't yet support temporary objects, so we need to fallback to the old one. Release note: None
rafiss
force-pushed
the
dsc-temp-sequence
branch
from
d00d23c
to
0e71b05
Compare
|
flake was #121342 tftr! bors r+ |
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new schema changer doesn't yet support temporary objects, so we need
to fallback to the old one.
This PR is stacked on top of #121376. Only the last commit needs to be reviewed.
informs #121377
Release note: None